fix(dialogs): backward compatible dialog usage #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="pg/modal-fix")
julia> using Pluto |
pankgeorg
force-pushed
the
pg/modal-fix
branch
from
7242b58
to
1e00320
Compare
pankgeorg
changed the title
pankgeorg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in Firefox 91 where the close() method is being called but it also doesn't exists (which is weird because it should have been polyfilled).
This may be a race condition though.
In any case, the optional chaining of a function call should be invoked with
?.(), to guard fornullup the chain.We also only call the polyfill when the element is not there and we guard the method calls vs the open attribute.