Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give "Loading more cells..." lots of vertical space so scroll restoration works better on Firefox #2901

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Apr 19, 2024

After this PR, if you refresh a long notebook on firefox, you might just end up at the same scroll position as before the reload. This used to not work because of the "Loading more cells..." mechanism.

@fonsp fonsp added the frontend Concerning the HTML editor label Apr 19, 2024
@fonsp fonsp changed the title Give "Loading more cells..." lots of vertical space so scroll restoration works better Give "Loading more cells..." lots of vertical space so scroll restoration works better on Firefox Apr 19, 2024
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="Loading-more-cells-scroll-restoration")
julia> using Pluto

@fonsp fonsp merged commit 126f25c into main Apr 19, 2024
3 of 4 checks passed
@fonsp fonsp deleted the Loading-more-cells-scroll-restoration branch April 19, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant