Add typings for segments #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/fontello/svgpath/blob/master/lib/path_parse.js#L4 I don't see declaration for |
|
@puzrin I'm not aware of any R/r command in path. Do you have a reference to some documentation? I also don't see it being mentioned here: https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths |
|
That was taken from ancient ages of [raphael(https://github.com/DmitryBaranovskiy/raphael)], when ie6 was alive. To be honest, i'm not sure how actual is that. Probably should be dropped here too. |
|
Hi guys. |
|
@mondeja thank you for the reference. Seems spec has also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the missing path commands. I used the names from https://www.w3.org/TR/SVG/paths.html#PathData
Maybe in a next PR these types could be exported as well. That might be useful