Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip installing FB does not include all scripts #1378

Closed
m4rc1e opened this issue Jun 6, 2017 · 4 comments
Closed

pip installing FB does not include all scripts #1378

m4rc1e opened this issue Jun 6, 2017 · 4 comments
Assignees
Labels

Comments

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 6, 2017

Hey folks,

Christoph Koeberlin pointed out that pip installing FB does not include all of the scripts.

screen shot 2017-06-06 at 10 37 24

There's no fix-fsselection.py etc

@graphicore
Copy link
Collaborator

it must be mentioned in setup.py. https://github.com/googlefonts/fontbakery/blob/master/setup.py#L66
We should probably write a function that collects all these scripts and registers them, simmilar to https://github.com/googlefonts/fontbakery/blob/master/bin/fontbakery#L9 (maybe we should reuse this, so there's no difference ever)

@davelab6 davelab6 added this to the 0.2.1 - Further improvements on reliability of checks and fixers milestone Jun 15, 2017
@davelab6
Copy link
Contributor

Sounds good, @felipesanches could you take care of this?

@felipesanches
Copy link
Collaborator

I reviewed and fixed this earlier this week and released FontBakery v0.2.1 on pypi. See #1406 (comment)

@davelab6
Copy link
Contributor

davelab6 commented Jul 9, 2017 via email

@davelab6 davelab6 modified the milestones: 0.3.1 - Further improvements on reliability of checks and fixers, 0.3.0 Rewrite internals for modularity, speed Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants