Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week3 #10

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Week3 #10

wants to merge 8 commits into from

Conversation

chichiglacierz
Copy link

No description provided.

mattiaslundberg
mattiaslundberg approved these changes Sep 3, 2019
View reviewed changes
Copy link
Collaborator

@mattiaslundberg mattiaslundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Approved

Some general comments:

  1. Remove code that you don't use/need, much easier to check
  2. Still the css issues from week 2, I think it's a good idea if you read up on some of the css material again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiaslundberg mattiaslundberg mattiaslundberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chichiglacierz @mattiaslundberg