do not store GroupOrderArticles with zero quantity and tolerance

[wvengen]

In GroupOrderArticle there is a scope ordered which means both "those articles that have been ordered", as well as "ordered by group name". In other models, ordered is used as the latter.

Cleaning this up, I could not find a reason why to keep GroupOrderArticles where all quantities are zero. These records are currently the bulk of the records in this table, and consume quite some computation and disk access time (reference to #49).

I've tested this on a copy of a production database with 1117655 GroupOrderArticles, which were reduced to a mere 12372 after the migration (the migration took 5 seconds on my development machine).

@bennibu as this affects the ordering algorithm, would you please comment if this is a good thing to do?

p.s. in the show group order page, articles not ordered are still presented (unless hidden by javascript)

[bennibu]

@wvengen, I can't remember exactly why we kept the "null results" of
GroupOrderArticles. I guess, this was for programming convenience, because
otherwise we had no result objects when fetching the GroupOrder result
in the GroupOrder#edit view.

I have not checked it yet, but I think it is a very good idea to clean
up the data.

Am 18.03.2014 17:55, schrieb wvengen:

In |GroupOrderArticle| there is a scope |ordered| which means both
"those articles that have been ordered", as well as "ordered by group
name". In other models, |ordered| is used as the latter.

Cleaning this up, I could not find a reason why to keep
|GroupOrderArticle|s where all quantities are zero. These records are
currently the bulk of the records in this table, and consume quite some
computation and disk access time (reference to #49
#49).

I've tested this on a production database with 1117655
|GroupOrderArticles|, which were reduced to a mere 12372 after the
migration (the migration took 5 seconds on my development machine).

@bennibu https://github.com/bennibu as this affects the ordering
algorithm, would you please comment if this is a good thing to do?

---

    You can merge this Pull Request by running

git pull https://github.com/wvengen/foodsoft feature-destroy_empty_goas

Or view, comment on, or merge it at:

#273

    Commit Summary

• do not store GroupOrderArticles with zero quantity and tolerance

  File Changes
  

• M app/models/group_order_article.rb
  https://github.com/foodcoops/foodsoft/pull/273/files#diff-0 (9)

• A db/migrate/20140318173000_delete_empty_group_order_articles.rb
  https://github.com/foodcoops/foodsoft/pull/273/files#diff-1 (9)

• M spec/integration/receive_spec.rb
  https://github.com/foodcoops/foodsoft/pull/273/files#diff-2 (7)

• M spec/models/group_order_article_spec.rb
  https://github.com/foodcoops/foodsoft/pull/273/files#diff-3 (4)

  Patch Links:
  

• https://github.com/foodcoops/foodsoft/pull/273.patch

• https://github.com/foodcoops/foodsoft/pull/273.diff

—
Reply to this email directly or view it on GitHub
#273.

pgp Schlüssel-ID: 0x3B2EE0A4
Fingerabdruck: 805F 73B1 9F45 4122 2FE6 ED75 0786 8427 3B2E E0A4

[wvengen]

Thanks for your reply! I feel confident to continue with this change now.