Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to copy articles #673

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Allow to copy articles #673

merged 1 commit into from
Oct 14, 2019

Conversation

JuliusR
Copy link
Contributor

@JuliusR JuliusR commented Jun 13, 2019

Fixes #541.

@JuliusR
Copy link
Contributor Author

JuliusR commented Jun 13, 2019

The article index already offers "edit" and "delete" buttons. This pull request adds a third button in between.

As a disadvantage, the table becomes even wider. I am not sure if this pull requests improves or worsens the usability on average. What do you think?

@wvengen
Copy link
Member

wvengen commented Jun 14, 2019

Could you make a screenshot (perhaps even of different window widths)?

@JuliusR
Copy link
Contributor Author

JuliusR commented Jun 14, 2019

Width in px without copy with copy
375 375-without 375-with
800 800-without 800-with
1024 1024-without 1024-with
1280 1280-without 1280-with
1600 1600-without 1600-with

@JuliusR
Copy link
Contributor Author

JuliusR commented Jun 14, 2019

After looking at it more carefully, I am not so much bothered about the wide tables. It seems that the real difficulty are the "line breaks" between the buttons. This increases the table row height and leads to a small vertical spacing of buttons. With my mouse, I can safely point on one of them, but what about touchscreen devices?

We can prevent the buttons from "line breaking" by putting them in separate columns, but that would always reserve lots of space for the buttons. We should also consider languages where "edit", "copy", and "delete" have more characters.

What are your thoughts?

@f0k
Copy link

f0k commented Jul 30, 2019

It seems that the real difficulty are the "line breaks" between the buttons.
[...]
We should also consider languages where "edit", "copy", and "delete" have more characters.

What are your thoughts?

edit duplicate delete

@wvengen
Copy link
Member

wvengen commented Oct 8, 2019

Ah, it's buttons breaking over the line is even better now, I'd say.
Icons may be nice, especially if we do it consistenly across the app.
Fine for now, I'd say.

@JuliusR
Copy link
Contributor Author

JuliusR commented Oct 14, 2019

I agree that we can merge this, and we can introduce icons later (if desired).

@wvengen wvengen merged commit 71bdf3b into master Oct 14, 2019
@wvengen wvengen deleted the feature/541-article-copy branch October 14, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy this article and add as new after edit.
3 participants