-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make install better #23
Conversation
- removed include/comp from install (probably not needed, otherwise should be somewhere else) - version file is written by cmake - lincense,readme is installed as well - gnuinstalldirs macro used to properly setup the install directories
…version.cmake ... If one wants multiple versions next to each other, there is the install_prefix which should be used for installation (e.g. /usr/local/opt/{foonathan_memory-0.5.9,foonathan_memory-0.61})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trusting the CMake code you wrote, haven't been keeping up to date there.
.vscode/.cmaketools.json
Outdated
@@ -0,0 +1,539 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to remove this file from Git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh good catch!,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you squash merge, it will go away (?) (I deleted it in the recent commit)
#include "detail/utility.hpp" | ||
#include "config.hpp" | ||
#include "utility.hpp" | ||
#include "../config.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, noticed that one as well, is fixed in a branch currently on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will be a small merge conflict probably
The cmake code is also almost the same as in https://github.com/rttrorg/rttr |
Thank you. |
You are welcome
Von meinem iPhone gesendet
… Am 03.03.2018 um 13:08 schrieb Jonathan Müller ***@***.***>:
Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Multiple version install is not really supported by cmake, but one can always install different version next to each other:
(e.g. /usr/local/opt/{foonathan_memory-0.5.9,foonathan_memory-0.6.1})
and then use one of them with
if that is a requirement.