Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Tweaks #5

Closed
6 tasks done
TomDonoghue opened this issue Sep 28, 2021 · 1 comment
Closed
6 tasks done

Minor Tweaks #5

TomDonoghue opened this issue Sep 28, 2021 · 1 comment

Comments

@TomDonoghue
Copy link
Member

TomDonoghue commented Sep 28, 2021

Minor potential tweaks to the repository files.

Python files:

  • In Python/02-GroupPSDs, the sub-selection of frequency ranges (under the 'Tuning the specparam algorithm' section) could use the trim_spectrum utility, which would be a little cleaner
  • In the Python notebooks, use a output_path = Path('../Output/') like is done for the data_path
  • PEP8 spacing updates: should be no space after argument assignment (eg function(a=1) not function(a = 1)).

R files:

  • Updated Python code in the R markdown files to match any updates made in the Python files
  • Update line length of text lines (these can be wrapped right?)
  • Check and fix spacing*

*Is there a standard spacing guideline for R? One thing I find a bit visually weird is the uneven spaces around assignements within function calls (ex: function(arg= val) as opposed to func(arg=val) or func(arg = val). Looking at this guide, I think the convention would be to have a space either side, so if it's all the same, I'd update to that.

@TomDonoghue TomDonoghue mentioned this issue Sep 28, 2021
@TomDonoghue
Copy link
Member Author

Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant