Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(quirk) You can "upload" files while the server is offline #1196

Closed
ntoff opened this issue Jan 22, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@ntoff
Copy link
Contributor

commented Jan 22, 2016

What were you doing?

Messing about, clicking random stuff to see what breaks.

What did you expect to happen?

Nothing (literally nothing, I expected it would do absolutely nothing)

What happened instead?

The "Upload locally / Upload to SD" option appears.

Branch & Commit or Version of OctoPrint

1.2.9 dev 35+g660de61

Printer model & used firmware incl. version

Not connected to one

Browser and Version of Browser, Operating System running Browser

Chrome Version 47.0.2526.111 m Windows 10 Pro

Link to octoprint.log

None, the server is offline so this must be a javascript thing running in the local browser?

Link to contents of terminal tab or serial.log

N/A (not connected)

Link to contents of Javascript console in the browser

http://i.imgur.com/vpMoZJ0.png

Screenshot(s) showing the problem:

(see above screenshot for issue/java console combo shot)

I have read the FAQ.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 22, 2016

Good point, that should be caught on the client side. Currently it will show that thing as soon as you drag a file on the tab, that should not happen if the server is offline.

Thanks for the heads-up!

@ntoff

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2016

It also shows up if you simply highlight the text on that "server is offline" message window, and drag that around on the screen, it doesn't even have to be a file.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 25, 2016

Should be fixed on both devel and maintenance branch, fix will be released with version 1.2.9.

@foosel foosel closed this Jan 25, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 3, 2016

Had to revert the commit that fixed the text being draggable issue, wasn't possible to get that to work cross browser, the API I used is only available in Chrome and apparently Opera so far, and in Firefox the drag'n'drop stopped working completely.

@ntoff

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2016

Probably not a huge issue anyway. One small request that I don't think is worth its own ticket, is it possible to filter the files that are viewable in the upload dialog box? Like with most programs you can filter out files they can't open, is it possible to have Octoprint's upload dialog only show STL and gcode files? Perhaps a configurable list of supported files?

foosel added a commit that referenced this issue Feb 9, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 9, 2016

Will now only show files allowed for upload (that can be more than just GCODE and STL, depending on the installed plugins).

foosel added a commit that referenced this issue Feb 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.