Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cura "retraction_combing" is parsed incorrectly #1208

Closed
2ndalpha opened this issue Feb 1, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@2ndalpha
Copy link
Contributor

commented Feb 1, 2016

What were you doing?

Slicing model with built-in Cura plugin.
In the Cura profile (.ini file) profile there is a line
"retraction_combing = All"

What did you expect to happen?

Slicer should slice with combing on.

What happened instead?

Combing is off.

Branch & Commit or Version of OctoPrint

Version: 1.2.8 (master branch)

Problematic code:

"enableCombing": 1 if self.get_boolean("retraction_combing") else 0,

How it actually should be handled: https://github.com/daid/Cura/blob/16cc0fa302f1ceccde229fdab6359bdbdc08b70c/Cura/util/sliceEngine.py#L533

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Feb 1, 2016

Hi @2ndalpha,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Please take a look at the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2016-02-15 22:50) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 3, 2016

Fixed by your own pr #1209, merged on maintenance and devel branches and will be released with 1.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.