Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$root.users.confirmUserSettingsDialog is not a function when editing access control options for a user #1357

Closed
javawizard opened this issue May 30, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@javawizard
Copy link

commented May 30, 2016

What were you doing?

Trying to make a non-admin user an admin. Go to Settings -> Access Control, click the edit button next to a user, then click Confirm. Happens whether or not you actually change either of the checkboxes.

What did you expect to happen?

Access control settings for the user to update, dialog to go away.

What happened instead?

Dialog stays, nothing changes, and I get VM877:3 Uncaught TypeError: $root.users.confirmUserSettingsDialog is not a function on the javascript console

Branch & Commit or Version of OctoPrint

1.2.11 & 1.2.10

Printer model & used firmware incl. version

SeeMeCNC Orion Delta

Browser and Version of Browser, Operating System running Browser

Chrome 50.0.2661.102 on Mac OS X 10.10.5 Yosemite

Link to octoprint.log

Working on it, though probably not relevant.

Link to contents of Javascript console in the browser

Minified, so probably less than helpful, but here's the stack trace anyway.

Uncaught TypeError: $root.users.confirmUserSettingsDialog is not a function
(anonymous function) @ VM877:3
(anonymous function) @ packed_libs.js?35d69079:1020
x.event.dispatch @ packed_libs.js?35d69079:4
y.handle @ packed_libs.js?35d69079:4

I have read the FAQ.

foosel added a commit that referenced this issue May 31, 2016

@foosel

This comment has been minimized.

Copy link
Owner

commented May 31, 2016

Thanks for spotting this (and the full bug report that made it extremely easy to fix this one). Has been solved in maintenance and devel branch and will be part of the next release.

In the meantime, anyone who runs into this can solve the problem for now by editing ~/.octoprint/users.yaml and adding admin to the roles of a user and then restarting the server, e.g. turning

test:
  roles:
  - user

into

test:
  roles:
  - user
  - admin

in order to give admin rights to the user test. Only a workaround until the fix is released, but should solve any issues for now hopefully.

@foosel foosel added this to the 1.2.12 milestone May 31, 2016

@foosel foosel closed this May 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.