Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive login doesn't trigger view model refresh #1374

Closed
foosel opened this issue Jun 15, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@foosel
Copy link
Owner

commented Jun 15, 2016

Problem

The initial passive login during startup gets triggered during the initial connection the server connected (onServerConnect). At that point however the view models have not been provided to the LoginStateViewModel via onAllBound and hence onUserLoggedIn cannot be called on the view models. The passive login therefore doesn't trigger any additional processing on view models that need that. Example: Plugin Manager doesn't initialize fully, neither does the Software Update plugin. Both never fetch their data from the server.

Workaround

Logout and log back in. That will force the trigger to run and initialize all view models correctly.

Solution

Have the initial passive login request not be sent out until the view models are known and provided to the LoginStateViewModel. onServerReconnect should still also trigger a passive login though.

@foosel foosel self-assigned this Jun 15, 2016

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Jun 16, 2016

Caused by the solution to #1364

@foosel foosel closed this in 397f762 Jun 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.