Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in software update plugin if "prerelease" is not contained in OctoPrint check config #1492

Closed
foosel opened this issue Sep 12, 2016 · 2 comments

Comments

Projects
None yet
1 participant
@foosel
Copy link
Owner

commented Sep 12, 2016

Problem

When tracking the Stable release channel, the prerelease flag might not be present in OctoPrint's check config. It still tries to fetch it though when populating the check config, resulting in a KeyError.

Solution

Use check.get("prerelease", None) instead of check["prerelease"] throughout the code.

@foosel foosel added this to the 1.2.16 milestone Sep 12, 2016

@foosel foosel self-assigned this Sep 12, 2016

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 12, 2016

Fixed in 0bb6f52

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 24, 2016

Fixed in 1.2.16 which was released yesterday. Also fixed on devel.

@foosel foosel closed this Sep 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.