Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in software update plugin if "prerelease" is not contained in OctoPrint check config #1492

Closed
foosel opened this issue Sep 12, 2016 · 2 comments
Closed

Error in software update plugin if "prerelease" is not contained in OctoPrint check config #1492

foosel opened this issue Sep 12, 2016 · 2 comments
Assignees
@foosel
Labels
bug Issue describes a bug done Done but not yet released
Milestone
1.2.16

Comments

@foosel
Copy link
Member

foosel commented Sep 12, 2016

Problem

When tracking the Stable release channel, the prerelease flag might not be present in OctoPrint's check config. It still tries to fetch it though when populating the check config, resulting in a KeyError.

Solution

Use check.get("prerelease", None) instead of check["prerelease"] throughout the code.
@foosel foosel added the bug Issue describes a bug label Sep 12, 2016
@foosel foosel added this to the 1.2.16 milestone Sep 12, 2016
@foosel foosel self-assigned this Sep 12, 2016
@foosel
Copy link
Member Author

foosel commented Sep 12, 2016

Fixed in 0bb6f52

@foosel foosel added the done Done but not yet released label Sep 12, 2016
@foosel
Copy link
Member Author

foosel commented Sep 24, 2016

Fixed in 1.2.16 which was released yesterday. Also fixed on devel.

@foosel foosel closed this as completed Sep 24, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@foosel foosel

Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Milestone
1.2.16
Development

No branches or pull requests
1 participant
@foosel