Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Hint for keyboard controls visible when keyboard controls are disabled. #1660
What were you doing?
Disabling keyboard controls that pop up over the webcam image (this part functions)
What did you expect to happen?
That the hint below the image would also disappear.
What happened instead?
"Hint: If you move your mouse over the picture, you enter keyboard control mode." appears even though keyboard controls are disabled.
Branch & Commit or Version of OctoPrint
Version: 1.3.0 (master branch)
none, I disabled them all to make sure it wasn't one of them.
Printer model & used firmware incl. version
Browser and Version of Browser, Operating System running Browser
google chrome + firefox both on windows 10 pro
Link to octoprint.log
Link to contents of terminal tab or serial.log
Screenshot(s) showing the problem:
I have read the FAQ.
Add a check to https://github.com/foosel/OctoPrint/blob/master/src/octoprint/templates/tabs/control.jinja2#L22 to also check whether keyboard controls are in fact enabled.
Tested in chrome / firefox on windows 10 and chrome on windows 7.