Issue #1780: Safari Webcam Fix. #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this 👍! That really made my day - it doesn't happen that often that a user reporting a problem sends in a PR to fix it themselves :D I'll also backport this to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Disables the disabling/enabling of the webcam if running in Safari as it doesn't disassociate the img src of the stream and thus multiples bandwidth unnecessarily.
How was it tested? How can it be tested by the reviewer?
In Safari.
Any background context you want to provide?
What are the relevant tickets if any?
#1780
Screenshots (if appropriate)
Further notes