Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcode viewer options interfere with each other #398

Closed
imitation opened this issue Mar 2, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@imitation
Copy link
Contributor

commented Mar 2, 2014

This is probably a know bug, but the gcode viewer's options interfere with each other. For example, when having "zoom in" enabled and clicking the "also show previous/next layer" checkbox, one needs to disable an re-enable the "zoom in" option for it to be recognized.

@foosel foosel added the type:bug label Mar 3, 2014

foosel added a commit that referenced this issue Mar 10, 2014

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2014

That one was evil, but I got it.

@foosel foosel closed this Mar 10, 2014

@imitation

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2014

Almost perfect now. When one of the "show x" options is changed, the view resets to the default view set by the zoom and center options, even when the view area was manually centered and zoomed on a different area.
Sorry for the nitpicking.

@foosel foosel reopened this Mar 11, 2014

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 11, 2014

Could be difficult to get this ironed out, but I'll see what I can do.
Transformation matrix tracking is a PITA ;)

@foosel foosel added status:accepted and removed type:bug labels Jul 27, 2014

foosel added a commit that referenced this issue Aug 8, 2014

Fixed a couple of issue with the gcode viewer
Most notably the interfering options tracked in #398, but also made "Center viewport on model" and "Zoom in on model" automatically deselect and de-apply if viewport gets manipulated by user, therefore properly allowing the re-select by the user to work to.

Closes #398
@foosel

This comment has been minimized.

Copy link
Owner

commented Aug 8, 2014

I think now I got it.

Small change: "Zoom in on model" and "Center viewport on model" get now automatically deselected too if the user manually changes zoom or pans around.

@foosel foosel closed this Aug 8, 2014

foosel added a commit that referenced this issue Aug 8, 2014

Fixed a couple of issue with the gcode viewer
Most notably the interfering options tracked in #398, but also made "Center viewport on model" and "Zoom in on model" automatically deselect and de-apply if viewport gets manipulated by user, therefore properly allowing the re-select by the user to work to.

Closes #398
(cherry picked from commit f195af0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.