Server api files inconsistent with new printer currentJob dictionary

[CapnBry]

(devel branch) When a file is selected as the current job, if you upload a new version of that file the printer state doesn't update with the new details in the webui and no updated gcode file is requested by the browser.

Tracking this down, the server/api/files.py class still references the old currentJob['filename'] which is now currentJob.file.name (or is it currentJob['file']['name'] I am not good at python) and also 'sd' I believe is 'file.location'?

In any instance it also won't prevent you from uploading a file that's currently printing either, which could be an even nastier problem.

[foosel]

Thanks for spotting this, should be fixed now.

[CapnBry]

It still doesn't properly detect a file change on the current job I'm afraid :(

In selectAndOrPrint() the variable filename isn't in scope, so that's None and nameToSelect I think has the full file path so that's not directly comparable to currentFilename either. printer.selectFile() I believe wants the full path so you can't just pass the basename. You can't pass both to selectAndOrPrint because that changes the function signature used by the SD streamer callback.

Oye vey! The simple solution would be to from os.path import basename; filename = basename(nameToSelect) but I'm not sure how happy you'd be with how clean that is.

[foosel]

Ookay... I changed some signatures, tested things both with local and SD files, both currently selected and not selected, both via the UI and directly via the API.

Can you try again too?

[CapnBry]

Confirmed working with selected / not selected / sd card / local. The whiteboard works!

Should I mention that the metadata doesn't fill in on the currently selected file when the background processing completes or will I get the hose again?

[foosel]

goes to fetch the hose

[foosel]

There you are :)

[CapnBry]

It is everything I ever wanted in a changeset and more.