Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: gcode causes a long list of tools to appear on the left side #539

Closed
sprior opened this issue Aug 10, 2014 · 8 comments

Comments

Projects
None yet
3 participants
@sprior
Copy link

commented Aug 10, 2014

  1. What were you doing? Trying to upload and print a gcode file that uses dual extruders
  2. What did you expect to happen? It to work as everything else has
  3. What happened instead? I got a large number of tools listed down the left instead of just two.
  4. Branch & Commit or Version: Version: 1.2.0-dev-102-g11fb18f
  5. Link to octoprint.log on gist.github.com or pastebin.com: https://gist.github.com/sprior/338a641ebcea094e5945#file-octoprint-log
  6. Link to contents of terminal tab on gist.github.com or pastebin.com: https://gist.github.com/sprior/a99f1b5e409a66c57d79

Attached is the gcode file that causes the problem.
dual2 gcode

I love cookies

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2014

Hi @sprior,

It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable.

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2014-08-24 04:40) I'll close this ticket so it doesn't clutter the bug tracker.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@foosel

This comment has been minimized.

Copy link
Owner

commented Aug 10, 2014

Apparently you finally discovered you love for pastries and made the bot happy, awesome ;)

Something went wrong with your attached gcode though, could you upload it somewhere and paste the link here or alternatively send me an email with it to osd at foosel dot net?

@foosel

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2014

@sprior why is your gcode trying to switch to tool no. 10000 in line 28?

; layer 1, Z = 0.28
T10000
M106 S0
T0

OctoPrint's gcode interpreter currently derives the number of extruders used in the file from the highest extruder number encountered while analyzing it, so here's the reason why that's happening. While I'll happily add a sane limit here to check against (I guess it's safe to say that there will be no printer with more than 10 extruders for the forseeable future and therefore that limit can be applied to the gcode analysis), that line there looks fishy to me.

foosel added a commit that referenced this issue Aug 11, 2014

Added sanity check for extruder selection in gcode files
Any T command targeting a number higher than the value specified in the settings for gcodeAnalysis.maxExtruders (defaults to 10) will be ignored and trigger a warning in the log file.

Fix for #539

foosel added a commit that referenced this issue Aug 11, 2014

@foosel

This comment has been minimized.

Copy link
Owner

commented Aug 11, 2014

So, encountering something like T10000 in the analyzed gcode shouldn't cause OctoPrint's UI to break anymore (both due to a sanity check in the backend and the UI now only displays tools that extually extrude filament according to the GCODE), but I'd still love to learn what that line was doing in your file in the first place @sprior ;)

@foosel foosel closed this Aug 11, 2014

@sprior

This comment has been minimized.

Copy link
Author

commented Aug 11, 2014

I'll have to claim being dumb on why the mine was there - it was generated by Simplify3D and I didn't touch it.

@sprior

This comment has been minimized.

Copy link
Author

commented Aug 11, 2014

Thanks for the sanity check though.

@sprior

This comment has been minimized.

Copy link
Author

commented Feb 12, 2015

Someone else with a MakerGear M2 just ran into this same issue and in trying to help him it took me a while to realize that this fix still hasn't made it into the current release. He's on the devel branch now and working, but how close are we to a 1.2 release? If that's not close can this fix be backported into the 1.1.* branch?

foosel added a commit that referenced this issue Mar 23, 2015

Added sanity check for extruder selection in gcode files
Any T command targeting a number higher than the value specified in the settings for gcodeAnalysis.maxExtruders (defaults to 10) will be ignored and trigger a warning in the log file.

Fix for #539
(cherry picked from commit 7d5c55f)

foosel added a commit that referenced this issue Mar 23, 2015

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 23, 2015

Has been backported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.