Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript syntax error calling WebSocket ctor when url port is blank in IE 11 #678

Closed
foofoodog opened this issue Dec 13, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@foofoodog
Copy link

commented Dec 13, 2014

It appears that IE 11 does not like having a colon in the socks URI when there is no port.
This causes things like file deletes to not update the file list.
Fix may be to not use the colon if you have no port.

var SOCKJS_URI = window.location.protocol.slice(0, -1) + "://" + (window.document ? window.document.domain : window.location.hostname) + (0 === window.location.port.length ? "" : ":" + window.location.port) + "/sockjs";

@GitIssueBot I love cookies

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Dec 13, 2014

Hi @foofoodog,

It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable.

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2014-12-27 16:10) I'll close this ticket so it doesn't clutter the bug tracker.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 4, 2015

That was fixed "accidentally" by switching over to using url_for instead of creating the URL for the SockJS endpoint manually.

@foosel foosel closed this May 4, 2015

@foofoodog

This comment has been minimized.

Copy link
Author

commented May 5, 2015

That was fixed "accidentally"

It was fixed "incidentally" as part of a code refactor.

Not seeing a link to a user story, work item or commit that shows all of the "url_for" work that this was swept up in.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.