New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing kwargs in PluginSettings remove #1177

Closed

richjoyce wants to merge 1 commit into OctoPrint:master from richjoyce:master

Contributor

richjoyce commented Jan 4, 2016

Trying to run self._settings.remove(path) in a plugin caused the following error before:

File "OctoPrint/src/octoprint/plugin/__init__.py", line 475, in __getattr__
    settings_name, args_mapper, kwargs_mapper = self.access_methods[item]
ValueError: need more than 2 values to unpack

This simply adds the third kwargs_mapper value as a passthrough lambda function, allowing remove to function as intended.


          Fix missing kwargs in PluginSettings remove

0d7965e

Member

foosel commented Jan 5, 2016

Thanks for spotting this.

Manually merged on maintenance and devel branch - master only gets updated on new releases (it really is stable).

foosel closed this

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet