Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1208 #1209

Closed
wants to merge 2 commits into from
Closed

Fixes #1208 #1209

wants to merge 2 commits into from

Conversation

2ndalpha
Copy link
Contributor

@2ndalpha 2ndalpha commented Feb 1, 2016

No description provided.

@foosel
Copy link
Member

foosel commented Feb 3, 2016

Thank you for spotting and fixing this.

As the section on pull requests in CONTRIBUTING.md linked on top of the PR and issue forms explains, PRs should only be done from a PR-specific branch against the devel branch (and important fixes will be ported back to the maintenance branch, to make it into the next release - see CONTRIBUTING.md for an explanation why that is the case). Hence I took the liberty to merge this manually on the maintenance and devel branches. I also added you to AUTHORS.md.

If there's a "next time", it would be great if you'd create the PR against devel and used a custom branch to reduce chances of unrelated commits getting in, you are saving us some manual work that way that can quickly accumulate.

Thanks! :)

@foosel foosel closed this Feb 3, 2016
@foosel foosel mentioned this pull request Feb 3, 2016
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2ndalpha @foosel