Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a printer profile option to allow centered origin #852
Conversation
beds Some printers have (0, 0) at the center of the bed. Circular beds commonly, but also some rectangular beds.
This comment has been minimized.
This comment has been minimized.
foosel
commented on src/octoprint/printer/profile.py in fbe50e3
Apr 15, 2015
|
Something's odd with the formatting here. I guess you wanted:
I'd rather move the option to |
This comment has been minimized.
This comment has been minimized.
foosel
commented on fbe50e3
Apr 15, 2015
This comment has been minimized.
This comment has been minimized.
|
Here's some updates based on feedback. I successfully sliced with the Cura addin for my printer which has the origin in the center. |
foosel
added a commit
that referenced
this pull request
Apr 16, 2015
* Proper origin visualization in gcode viewer for centered rectangular * Validation of origin profile entry * Auto-migration of existing profiles upon load * Added changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
markwal commentedApr 15, 2015
This is an attempt at fixing #682. It doesn't add arbitrary origin, but adds a checkbox for the most common one (other than the default lower left). Some printers have (0, 0) at the center of the bed. Circular beds commonly, but also some rectangular beds.