Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a printer profile option to allow centered origin #852

Merged
merged 3 commits into from Apr 16, 2015

Conversation

Projects
None yet
2 participants
@markwal
Copy link
Collaborator

commented Apr 15, 2015

This is an attempt at fixing #682. It doesn't add arbitrary origin, but adds a checkbox for the most common one (other than the default lower left). Some printers have (0, 0) at the center of the bed. Circular beds commonly, but also some rectangular beds.

Add a printer profile option to allow centered origin on rectangular
beds

Some printers have (0, 0) at the center of the bed.  Circular beds
commonly, but also some rectangular beds.
@foosel

This comment has been minimized.

Copy link

commented on src/octoprint/printer/profile.py in fbe50e3 Apr 15, 2015

Something's odd with the formatting here. I guess you wanted:

* - ``centeredOrigin``
  - ``bool``
  - Whether the printer's origin is in the center of the bed, otherwise the origin is assumed to be the lower left and all valid coordinates positive.

I'd rather move the option to volume.origin though, make it a string that accepts center, lowerleft and (later) x,y values (with center staying the default for a circular form factor).

@foosel

This comment has been minimized.

Copy link

commented on fbe50e3 Apr 15, 2015

That takes care of the settings and the gcode viewer, but it completely forgoes the slicer which needs that information as well.

Take a look here, here and here.

.oO( Maybe I should extract that "where to position the model" stuff somehow so it doesn't need to be reimplemented in every slicer )

markwal added some commits Apr 15, 2015

Move the centered option into printer volume
Also, modify the cura slicer to recognize the setting and avoid
adjusting the model position, just leave it in the center where it would
be on a circular platform
@markwal

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 15, 2015

Here's some updates based on feedback. I successfully sliced with the Cura addin for my printer which has the origin in the center.

@foosel foosel merged commit 5a27ab6 into foosel:devel Apr 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

foosel added a commit that referenced this pull request Apr 16, 2015

Small fixes prior to merge of #852
   * Proper origin visualization in gcode viewer for centered rectangular
   * Validation of origin profile entry
   * Auto-migration of existing profiles upon load
   * Added changelog entry

@markwal markwal deleted the markwal:centeredorigin branch May 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.