-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pykeepass #10
base: master
Are you sure you want to change the base?
Update pykeepass #10
Conversation
7735e5f
to
a226820
Compare
Python 3.4 isn't getting security updates anymore, support was dropped by lxml. |
Can you put the version pinning back into setup.py? |
OK, I get why you did it in the first place. But as every dependency can be used for an attack just as easily, wouldn't it be better to pip freeze all dependencies to the requirements.txt and encourage people to install via |
That’s true, it would be the best. But people never install CLI packages in a virtual env, they do it in system or user python path. Freezing all dependencies breaks a lot of things for other installed apps...
Remove everything else please to keep the focus of the PR so I can merge it :) |
066681f
to
cef1c16
Compare
I created another pull request for the other changes. |
I couldn't open my db due to libkeepass/pykeepass#152.