Fix merging of adjacent spans #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background: We merge separate spans that cover a continuous logical span of text. E.g: [(0, 17), (17, 35)] -> [(0, 35)] Previously we sometimes encountered negative span annotations like this one: (208, 147). This was caused by incorrect merging of adjacent annotations. Instead of filtering the end positions using the original start positions we filtered using the already filtered start positions. As a result no end positions were ever removed, meaning the function produced two lists of different lengths, the longer of which (with the end positions) was truncated by the call to zip.
|
Thanks for the fix and the explanation! It would be great if you could also give the function a name that actually indicates what it's doing, as well as review the docstring and any comments. |
|
Sorry, but I am not interested in writing further documentation as part of this bugfix PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: We merge separate spans that cover a continuous logical span of text. E.g: [(0, 17), (17, 35)] -> [(0, 35)]
Previously we sometimes encountered negative span annotations like this one: (208, 147). This was caused by incorrect merging of adjacent annotations. Instead of filtering the end positions using the original start positions we filtered using the already filtered start positions. As a result no end positions were ever removed, meaning the function produced two lists of different lengths, the longer of which (with the end positions) was truncated by the call to zip.