Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old upgrade steps #3615

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Remove old upgrade steps #3615

merged 1 commit into from
Jun 20, 2023

Conversation

bbirman
Copy link
Member

@bbirman bbirman commented Jun 19, 2023

No description provided.

bbirman
bbirman commented Jun 19, 2023
View reviewed changes
libs/SmartStore/SmartStore/Classes/SFSmartStore+Internal.h
/**
@return The legacy key used to encrypt the store.
*/
+ (NSString *)legacyEncKey;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the implementation in #3591 but missed this internal header and the upgrade step that calls it

@mobilesdk-bot
Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFSmartStore.m Nullability Memory error nil returned from a method that is expected to return a non-null value 368 9
SFSmartStore.m NSError** null dereference Coding conventions (Apple) Potential null dereference. According to coding standards in 'Creating and Returning NSError Objects' the parameter may be null 1343 16
SFSmartStore.m Nullability Memory error nil passed to a callee that requires a non-null 1st parameter 1419 28
SFSmartStore.m Dead initialization Unused code Value stored to 'ids' during its initialization is never read 1848 21

Tests results for SmartStore

Generated by 🚫 Danger

@bbirman bbirman merged commit 766c38b into forcedotcom:dev Jun 20, 2023
@bbirman bbirman deleted the andmoreencryption branch June 20, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmathurin wmathurin wmathurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbirman @mobilesdk-bot @wmathurin