Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(orgbrowser): add support for StandardValueSet #3992

Merged
merged 5 commits into from
Apr 14, 2022
Merged

Conversation

mohanraj-r
Copy link
Contributor

What does this PR do?

Builds the community contribution #3982 from @sbresin 🎉

Adds support for retrieving StandardValueSet Metadata with the Org Browser.

There is no API call that lists all StandardValueSets, so i hardcoded the list of their names. The list comes from here: https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/standardvalueset_names.htm

What issues does this PR fix or reference?

#1579

Functionality Before

None: Currently it is not possible at all to retrieve StandardValueSets from the OrgBrowser.

Functionality After

Screen Shot 2022-03-29 at 16 38 46

@mohanraj-r mohanraj-r requested a review from a team as a code owner March 31, 2022 20:28
@trinasfdx trinasfdx added the status:in review pr/issue is being reviewed label Apr 1, 2022
@mohanraj-r mohanraj-r added the type:community-contrib Community Contribution Pull Requests label Apr 1, 2022
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-10936512

Copy link
Contributor

@klewis-sfdc klewis-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the contribution @sbresin!

✅ Org Browser Retrieve Source works for StandardValueSets
✅ Org Browser Retrieve Source and Open works for StandardValueSets
✅ Org Browser Retrieve Source for all Standard Value Sets via directory-level retrieve button works
✅ Adding a new picklist option to a standard value set and then re-running Retrieve Source via Org Browser to retrieve the new value works (also works via right click on file in Explorer)
✅ Adding a new picklist option to a standard value set and then running SFDX: Diff file against org works and shows correct diff

@klewis-sfdc klewis-sfdc merged commit ca91cfc into develop Apr 14, 2022
@klewis-sfdc klewis-sfdc deleted the pr/3982 branch April 14, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed status:in review pr/issue is being reviewed type:community-contrib Community Contribution Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants