fix: improve messaging for force ignore old vs new parsers #324
Conversation
test/resolve/forceIgnore.test.ts
Outdated
| @@ -23,6 +23,35 @@ describe('ForceIgnore', () => { | |||
|
|
|||
| afterEach(() => env.restore()); | |||
|
|
|||
| (!process.platform.includes('win') ? it : it.skip)( | |||
There was a problem hiding this comment.
@brpowell I skipped this one test for windows. Having no luck with the stubs working. Not sure why, but would appreciate any ideas.
There was a problem hiding this comment.
Will it not work even with the wrapping of process.emitWarning in ForceIgnore? I don't want to skip tests based on platform, especially windows.
There was a problem hiding this comment.
@brpowell even when wrapped. My first attempt was to stub process.emitWarning, no joy. Then wrap with private function. I agree that skipping tests is a bad idea, esp for windows.
There was a problem hiding this comment.
I can take a closer look at what's going wrong, likely not until tomorrow or next week though.
There was a problem hiding this comment.
@brpowell Thanks
|
@brpowell Just checking if you have had a chance to look at the mock trouble I am having with the one test on windows? |
|
@peternhale @brpowell - the stubs for the 2 libraries used in the |
|
@brpowell Could I get a review on this. Steve fixed the windows test, so I think we are good to go on this PR. |
* fix: improve messaging for force ignore old vs new parsers @W-9051899@ * chore: get more details on test failure * chore: add private cover for process.emitWarning Doing this for widnows * chore: skip on windows * test: update test to stub properly for the usecase Co-authored-by: Steve Hetzel <shetzel@salesforce.com> Co-authored-by: Bryan Powell <b.powell@salesforce.com>
* fix: improve messaging for force ignore old vs new parsers @W-9051899@ * chore: get more details on test failure * chore: add private cover for process.emitWarning Doing this for widnows * chore: skip on windows * test: update test to stub properly for the usecase Co-authored-by: Steve Hetzel <shetzel@salesforce.com> Co-authored-by: Bryan Powell <b.powell@salesforce.com>
What does this PR do?
Improves the user messaging around old and new parsers used to parse foriceignore files
What issues does this PR fix or reference?
@W-9051899@
Functionality Before
Message displayed to user was a bit confusing, just providing a better message and reducing the number of diffs displayed
Functionality After
Better message