fix: show iso-git err qty in logs #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Apr 3, 2024
| @@ -280,7 +280,7 @@ export class ShadowRepo { | |||
| }); | |||
| } catch (e) { | |||
| if (e instanceof git.Errors.MultipleGitError) { | |||
| this.logger.error('multiple errors on git.add', e.errors.slice(0, 5)); | |||
| this.logger.error(`${e.errors.length} errors on git.add, showing the first 5:`, e.errors.slice(0, 5)); | |||
There was a problem hiding this comment.
any specific reason it shows only the first 5 errors?
There was a problem hiding this comment.
large deployments could result a 4-5 digit number of these?
mshanemc
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updates debug log about isogit error to show qty of errors (logs only include the first 5).
What issues does this PR fix or reference?
@W-15347866@