Add compare method support to .in() and .fullJoin() #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Chris! I committed your changes. Yes I haven't updated it in a
while as you can see, but if you have more changes let me know. Thank you!
…On Wed, Mar 14, 2018 at 5:46 PM, Chris Kirk ***@***.***> wrote:
Currently .fullJoin and .in only support matching with string fields.
This enables support using the comparison functions similar to .join and .
leftJoin
Happy to make any changes as needed! But hadn't seen much development
here, so wanted to open the PR and see if anyone is around / open to taking
in new changes 🙃
------------------------------
You can view, comment on, or merge this pull request online at:
#30
Commit Summary
- Supporting compare functions in .in() to enable full joins to use
compare functions.
- added comment about jinqjs additions.
- Cleaning up code to support .in() regular comparisons.
- reordered comment.
- bugfix.
File Changes
- *M* jinqjs.js <https://github.com/fordth/jinqJs/pull/30/files#diff-0>
(103)
- *M* jinqjs.min.js
<https://github.com/fordth/jinqJs/pull/30/files#diff-1> (2)
Patch Links:
- https://github.com/fordth/jinqJs/pull/30.patch
- https://github.com/fordth/jinqJs/pull/30.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#30>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJoGABlVC-lK-U9AREuGZU1Rj8OomfLMks5teY--gaJpZM4SrOgc>
.
|
|
Thanks a ton, @fordth ! How would you feel about tagging a v1.6.2 so we can use this locked version w/ yarn/npm? |
|
All set!
…On Wed, Mar 14, 2018 at 8:37 PM, Chris Kirk ***@***.***> wrote:
Thanks a ton, @fordth <https://github.com/fordth> ! How would you feel
about tagging a v1.6.2 so we can use this locked version w/ yarn/npm?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJoGANWUyMuPXf9X8XsaKfC51glQkzGUks5tebewgaJpZM4SrOgc>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
.fullJoinand.inonly support matching with string fields. This enables support using the comparison functions similar to.joinand .leftJoinHappy to make any changes as needed! But hadn't seen much development here, so wanted to open the PR and see if anyone is around / open to taking in new changes 🙃