Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze yarn to 1.21.1 #5786

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Freeze yarn to 1.21.1 #5786

merged 1 commit into from
Feb 5, 2020

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jan 28, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

As mentioned in Introducing Yarn 2 ! on DEV by its maintainer and by @abenettt in #5740 Yarn 2 is out, and we don't support it, thus running the risk of breaking something in the future when Yarn 2 will be the default install.

As mentioned in the article:

If you don't want to upgrade all of your projects, just run yarn policies set-version ^1 in the repositories that need to stay on Yarn 1, and commit the result. Yarn will always prefer the checked-in binaries over the global ones, making it the best way to ensure that everyone in your team shares the exact same release!

I did just that, we can revisit which yarn version and how to upgrade to 2 in the future, in the meantime we should enforce this

Related Tickets & Documents

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 28, 2020
@abenerd
Copy link
Contributor

abenerd commented Jan 28, 2020

@rhymes I tried this too but when I executed the file to get the version like

 .yarn/releases/yarn-1.21.1.js --version

I got told I'm on yarn 2.0.0-rc.27

@rhymes
Copy link
Contributor Author

rhymes commented Jan 28, 2020

@abenettt I think this change is to make sure yarn install picks up the correct yarn.

What happens if you exit the terminal, go into the directory again and type yarn -v ?

@abenerd
Copy link
Contributor

abenerd commented Jan 28, 2020

@rhymes I'm having the same result then.

@rhymes
Copy link
Contributor Author

rhymes commented Jan 28, 2020

@abenettt mmm how did you install Yarn 2 then?

@abenerd
Copy link
Contributor

abenerd commented Jan 28, 2020

@rhymes Aaaaah I ran

yarn policies set-version berry

in my home directory and apparently as the repo lies within a child directory it takes precedence. Now that I removed it, it works again.

Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how long until yarn 2 is compatible with most projects

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 28, 2020
.yarnrc Show resolved Hide resolved
Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@mstruve mstruve merged commit 89852ab into forem:master Feb 5, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 5, 2020
@rhymes rhymes deleted the rhymes/freeze-yarn-to-1_21_1 branch February 6, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants