Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pest from version '1.x.x' to '2.x.x'. #67

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Conversation

foresterre
Copy link
Owner

@foresterre foresterre commented Nov 22, 2018

The handled breaking changes are:

  • 'operation_sequence' now handles whitespace explicitly.
  • EOI is no longer silent, so the rule will be filtered out before

Additionally, test_setup from the operations module is renamed to mod_test_includes to be
in line with the other test includes module.

A few lines have been moved within the same module (in particular the filter3x3 parsing code), for
improved readability.

Future:

  • Looking at the pest 2.0.0 release highlights, 'const _GRAMMER' might no longer be
    necessary to refresh the included pest grammar. It is not too clear from the docs
    whether that is the case or not. I left it in for now; it doesn't seem broken down.

Issue: #63

The handled breaking changes are:
- 'operation_sequence' now handles whitespace explicitly.
- EOI is no longer silent, so the rule will be filtered out before

Additionally, test_setup from the operations module is renamed to mod_test_includes to be
in line with the other test includes module.

A few lines have been moved within the same module (in particular the filter3x3 parsing code), for
improved readability.

Future:
- Looking at the pest 2.0.0 release highlights, 'const _GRAMMER' might no longer be
necessary to refresh the included pest grammar. It is not too clear from the docs
whether that is the case or not. I left it in for now; it doesn't seem broken down.
@foresterre foresterre merged commit 288c5b2 into master Nov 22, 2018
@foresterre foresterre deleted the update_pest branch November 22, 2018 16:00
@foresterre foresterre mentioned this pull request Nov 22, 2018
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant