Add user tests #75
Merged
Add user tests #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're actually doing a bit of a dance because currently we exit the program with std::process::exit(0) if we run --license or -H <value>. To test whether these commands work right now, we use Command and check whether the value of the stdout starts with what we expect.
A future addition which would greatly simplify writing these tests would be parameterized tests. Something to look into after the next release. Probably the current set of integration tests can be simplified a bit more too. In sic_lib::processor::conversion we already test using "manual parameterized like loop over vec" tests. The way it is handled over there is suboptimal in at least one way: It is registered as a single test case, even though we test all formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the attached issue.
Issue: #71