Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FORGE-2265: Refactoring the CDI Commands #543

Merged
merged 1 commit into from
Mar 3, 2015
Merged

FORGE-2265: Refactoring the CDI Commands #543

merged 1 commit into from
Mar 3, 2015

Conversation

agoncal
Copy link
Contributor

@agoncal agoncal commented Mar 2, 2015

No description provided.

@forge-bot
Copy link
Contributor

Build 763 is now running using a merge of 51a5907

@forge-bot
Copy link
Contributor

Build 790 is now running using a merge of 51a5907

@forge-bot
Copy link
Contributor

Build 763 outcome was FAILURE using a merge of 51a5907
Summary: Tests failed: 153 (153 new), passed: 135, ignored: 15 Build time: 0:02:35

Build problems:

Failed tests detected
Process exited with code 1

Failed tests

org.jboss.forge.addon.text.highlight.HighlighterTestCase: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.text.highlight.HighlighterTestCase.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.text.InflectorServiceTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.text.InflectorServiceTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.manager.AddonManagerTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.manager.AddonManagerTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.manager.ui.AddonListCommandTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.manager.ui.AddonListCommandTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.project.AddonProjectConfiguratorTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.project.AddonProjectConfiguratorTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.ui.NewFurnaceTestCommandTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.ui.NewFurnaceTestCommandTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.ui.NewFurnaceTestSetupCommandTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.ui.NewFurnaceTestSetupCommandTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.ui.NewUICommandWizardTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.ui.NewUICommandWizardTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.convert.CDIConverterTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.convert.CDIConverterTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.convert.exported.ConverterFactoryTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.convert.exported.ConverterFactoryTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.convert.exported.StringToExportedConverterTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.convert.exported.StringToExportedConverterTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)


##### there are 143 more failed tests, see build details

@forge-bot
Copy link
Contributor

Build 790 outcome was FAILURE using a merge of 51a5907
Summary: Tests failed: 48 (3 new), passed: 109, ignored: 12 Build time: 0:01:36

Build problems:

Failed tests detected
Process exited with code 1

Failed tests

org.jboss.forge.addon.parser.xml.XMLSourceFactoryTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.parser.xml.resources.XMLResourceTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.ui.UIWizardDiscoveryTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.text.InflectorServiceTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.text.highlight.HighlighterTestCase: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.convert.CDIConverterTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.convert.exported.ConverterFactoryTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.convert.exported.StringToExportedConverterTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.environment.CDIEnvironmentTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

test.org.jboss.forge.addon.facets.factory.FacetFactoryTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

test.org.jboss.forge.addon.facets.factory.FacetFactoryAmbiguousInstallTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)


##### there are 38 more failed tests, see build details

gastaldi
gastaldi reviewed Mar 3, 2015
View reviewed changes
...ee/tests/src/test/java/org/jboss/forge/addon/javaee/cdi/ui/CDINewInterceptorCommandTest.java
@@ -111,7 +111,7 @@ public void checkCommandMetadata() throws Exception
assertTrue(controller.hasInput("targetPackage"));
assertTrue(controller.hasInput("overwrite"));
assertTrue(controller.hasInput("interceptorBinding"));
assertTrue(controller.getValueFor("targetPackage").toString().endsWith("unknown"));
assertTrue(controller.getValueFor("targetPackage").toString().endsWith("beans"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using the created constant instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@forge-bot
Copy link
Contributor

Build 791 is now running using a merge of f41f313

@forge-bot
Copy link
Contributor

Build 764 is now running using a merge of f41f313

@forge-bot
Copy link
Contributor

Build 791 outcome was FAILURE using a merge of f41f313
Summary: Tests failed: 48, passed: 109, ignored: 12 Build time: 0:01:54

Build problems:

Failed tests detected
Process exited with code 1

Failed tests

org.jboss.forge.addon.text.InflectorServiceTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.text.highlight.HighlighterTestCase: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.convert.CDIConverterTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.convert.exported.ConverterFactoryTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.convert.exported.StringToExportedConverterTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.environment.CDIEnvironmentTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

test.org.jboss.forge.addon.facets.factory.FacetFactoryTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

test.org.jboss.forge.addon.facets.factory.FacetFactoryAmbiguousInstallTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

test.org.jboss.forge.addon.facets.constraints.FacetConstraintsTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

test.org.jboss.forge.addon.facets.constraints.FacetOptionalConstraintsTest: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)

org.jboss.forge.addon.parser.json.JsonTestCase: java.lang.IllegalArgumentException: MALFORMED
    at java.util.zip.ZipCoder.toString(ZipCoder.java:58)
    at java.util.zip.ZipFile.getZipEntry(ZipFile.java:567)


##### there are 38 more failed tests, see build details

@forge-bot
Copy link
Contributor

Build 764 outcome was FAILURE using a merge of f41f313
Summary: Tests failed: 153, passed: 135, ignored: 15 Build time: 0:02:24

Build problems:

Failed tests detected
Process exited with code 1

Failed tests

org.jboss.forge.addon.text.highlight.HighlighterTestCase: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.text.highlight.HighlighterTestCase.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.text.InflectorServiceTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.text.InflectorServiceTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.manager.AddonManagerTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.manager.AddonManagerTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.manager.ui.AddonListCommandTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.manager.ui.AddonListCommandTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.project.AddonProjectConfiguratorTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.project.AddonProjectConfiguratorTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.ui.NewFurnaceTestCommandTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.ui.NewFurnaceTestCommandTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.ui.NewFurnaceTestSetupCommandTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.ui.NewFurnaceTestSetupCommandTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.addons.ui.NewUICommandWizardTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.addons.ui.NewUICommandWizardTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.convert.CDIConverterTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.convert.CDIConverterTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.convert.exported.ConverterFactoryTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.convert.exported.ConverterFactoryTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)

org.jboss.forge.addon.convert.exported.StringToExportedConverterTest: java.lang.RuntimeException: Could not generate @Deployment for org.jboss.forge.addon.convert.exported.StringToExportedConverterTest.getDeployment()
    at org.jboss.forge.arquillian.impl.FurnaceDeploymentScenarioGenerator.generate(FurnaceDeploymentScenarioGenerator.java:87)
    at org.jboss.arquillian.container.test.impl.client.deployment.DeploymentGenerator.generateDeployment(DeploymentGenerator.java:79)


##### there are 143 more failed tests, see build details

gastaldi added a commit that referenced this pull request Mar 3, 2015
@gastaldi
Merge pull request #543 from agoncal/FORGE-2265
ced82e0 
FORGE-2265: Refactoring the CDI Commands
@gastaldi gastaldi merged commit ced82e0 into forge:master Mar 3, 2015
@gastaldi
Copy link
Member

gastaldi commented Mar 3, 2015

Fantastic! Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agoncal @forge-bot @gastaldi