FORGE-1005 Modified equals/hashcode generators to consider inheritance hierarchies. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e hierarchies. The generator now includes a delegation to super.hashCode() and super.equals() when a super class not of type Object is detected for the provided class. Additionally, bugs in the earlier equals generator were fixed. The equals method no longer returns immediately when the first field is equal. Additionally, instanceof is used to verify that the Class instances are equal to account for subclasses, thereby ensuring that proxied instances are also equal. Changes were also done to incorporate new methods in the Field API. Methods are now available to detect if a field is transient or volatile, or is an Array. Transient and array field detection is required for generating the equals and hashCode methods.
|
I've made some heavy updates to the Refactory class. Most of the changes involve supporting all primitive types, array types, and non-compatibility-breaking changes in the Java Parser API. Modified the test suite to reflect these. |
|
Hoooooly shit. |
There was a problem hiding this comment.
Why is isPrimitive receiving a String type as an argument ?
Also added checks to prevent static fields from being used in the generated methods.
There was a problem hiding this comment.
Perhaps it would be better to move this method to org.jboss.forge.parser.java.util.Strings class ?
|
Perfect ! |
|
Squashed and merged: 9b87cdb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generator now includes a delegation to super.hashCode() and super.equals() when a super class not of type Object is detected for the provided class.
Additionally, bugs in the earlier equals generator were fixed. The equals method no longer returns immediately when the first field is equal. Additionally, instanceof is used to verify that the Class instances are equal to account for subclasses, thereby ensuring that proxied instances are also equal.