New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block unlocker marking all blocks as orphaned #48

Open
CaptainMeatloaf opened this Issue Dec 11, 2017 · 8 comments

Comments

Projects
None yet
6 participants
@CaptainMeatloaf

CaptainMeatloaf commented Dec 11, 2017

I'm attempting to set up a pool for turtlecoin (https://github.com/turtlecoin/turtlecoin), at http://turtlepool.space, and appear to be having issues with getting the pool to unlock the blocks correctly.

UPDATE: For those using TurtleCoin, this was fixed, this bug still may apply to other cryptonote currencies.

I have set up the daemon and wallet (using simplewallet), and the pool appears to connect to them and read ok.

image
I then set up my miner to mine to the pool. It has managed to find several successful blocks, however when a block is discovered, the block becomes orphaned after the maturity depth has passed.

There are no obvious errors in any of the logs.

Upon further inspection, it appears that there is an off-by-one error in blockUnlocker.js.

This can be temporarily fixed by changing line 48 of blockUnlocker.js from
apiInterfaces.rpcDaemon('getblockheaderbyheight', {height: block.height}, function(error, result){
to
apiInterfaces.rpcDaemon('getblockheaderbyheight', {height: block.height + 1}, function(error, result){

However this feels like somewhat of a hack.

Please let me know if you need any more info.

@CaptainMeatloaf CaptainMeatloaf changed the title from Forknote pool not reading block worth correctly to Block unlocker marking all blocks as orphaned Dec 12, 2017

@pipozzz

This comment has been minimized.

pipozzz commented Dec 26, 2017

How did you do reprocessing of bad labeled blocks?

@CaptainMeatloaf

This comment has been minimized.

CaptainMeatloaf commented Dec 26, 2017

I didn't - as I was solo mining and it was a testing phase for the pool, all the blocks found went to me anyway

@BisWang

This comment has been minimized.

BisWang commented Feb 11, 2018

I have high rate orphan on my turtlecoin pool, but I use the same forknote-pool on intense coin it have normal orphan rate
This problem cause by turtlecoin or?

@CaptainMeatloaf

This comment has been minimized.

CaptainMeatloaf commented Feb 11, 2018

That's a bug in Turtlecoin that we as the pool ops have a fix for - ask on discord.

@pmitchev pmitchev referenced this issue Mar 12, 2018

Closed

Orphan #75

@fairmarketcoin

This comment has been minimized.

fairmarketcoin commented Mar 12, 2018

what's the fix for this at the coins level?

@alferz

This comment has been minimized.

alferz commented Mar 18, 2018

Same issue on leviarcoin. I made the same fix as OP, but does anyone have a better one? Maybe an option in the config file to address the off by one issue for crappily coded coins?

@madradio

This comment has been minimized.

madradio commented Mar 20, 2018

Could anyone of you post the fix for this issue here?

@CaptainMeatloaf

This comment has been minimized.

CaptainMeatloaf commented Mar 20, 2018

You can look at the commit history of TurtleCoin to find the fix, it was done pretty early on

dvandal added a commit to dvandal/cryptonote-nodejs-pool that referenced this issue May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment