Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListField could be initialized with empty array #40

Closed
MiroslavPetrik opened this issue Jun 2, 2023 · 2 comments
Closed

ListField could be initialized with empty array #40

MiroslavPetrik opened this issue Jun 2, 2023 · 2 comments
Labels
bug Something isn't working nice to have Feature not widely used released

Comments

@MiroslavPetrik
Copy link
Member

MiroslavPetrik commented Jun 2, 2023 •
edited
Loading

image

As the image shows, the builder type cannot be matched to empty array types as never[]. Some type hint for the fields object is required.

  • edge case, form should be submittable with empty array when initialized without requiring user change
  • maybe not needed as it requires user to click the "Add item" button
    • instead, better to initialize with [someField()]
@MiroslavPetrik MiroslavPetrik added bug Something isn't working nice to have Feature not widely used labels Jun 2, 2023
@MiroslavPetrik
Copy link
Member Author

Solution is to have better builder utils, so no manual building and typing is needed

github-actions bot pushed a commit that referenced this issue Nov 30, 2023
@semantic-release-bot
chore(release): 3.7.0
3fea940 
# [3.7.0](v3.6.4...v3.7.0) (2023-11-30)

### Features

* **ListField:** improved builder ([35d19aa](35d19aa)), closes [#40](#40)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working nice to have Feature not widely used released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MiroslavPetrik