Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove pkg/errors usage #160

Merged
merged 1 commit into from
Mar 6, 2024
Merged

chore: remove pkg/errors usage #160

merged 1 commit into from
Mar 6, 2024

Conversation

nvloff-f3
Copy link
Contributor

@nvloff-f3 nvloff-f3 commented Mar 6, 2024 •
edited
Loading

No need to use external library if stdlib handles it.

@nvloff-f3 nvloff-f3 requested a review from a team as a code owner March 6, 2024 07:48
janakerman-form3
janakerman-form3 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@janakerman-form3 janakerman-form3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, so approved. However, would be good to understand the motivation for posterity. 🙏

@nvloff-f3
Copy link
Contributor Author

@janakerman-form3 thanks I added a sentence to the PR description 👍

@nvloff-f3 nvloff-f3 merged commit 796fde1 into master Mar 6, 2024
1 check passed
@nvloff-f3 nvloff-f3 deleted the nvloff-errors branch March 6, 2024 09:25
@nvloff-f3 nvloff-f3 mentioned this pull request Mar 17, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlornac mlornac mlornac approved these changes

@janakerman-form3 janakerman-form3 janakerman-form3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvloff-f3 @mlornac @janakerman-form3