feat: Add redis locking strategy #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gfyrag
commented
Mar 15, 2022
gfyrag
commented
- Add redis locking strategy.
- Add TLS connection to redis.
This PR allow to configure the lock strategy used by the ledger to prevent concurrent transactions. Following flag was defined : * --lock-strategy: memory, none, or redis (default: memory) The 'none' strategy disable locking. The client could handle the retry itself. The 'memory' strategy is the default and is the same as before. The 'redis' strategy use a lock on redis. 'redis' strategy use additionnal flags : * --lock-strategy-redis-url: Url of the redis server * --lock-strategy-redis-duration: Duration before redis remove the lock whatever the job is terminated or not (prevent deadlock if a service crash) * --lock-strategy-redis-retry: It is the waiting duration between two attempts to get a lock (if already take by another transaction).
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 72.83% 73.99% +1.16%
==========================================
Files 76 76
Lines 3011 3096 +85
==========================================
+ Hits 2193 2291 +98
+ Misses 648 634 -14
- Partials 170 171 +1
Continue to review full report at Codecov.
|
flemzord
approved these changes
Mar 15, 2022
gfyrag
deleted the
feature/num-344-ledger-backport-redis-lock-from-ledger
branch
flemzord
pushed a commit
that referenced
this pull request
Jun 7, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 20, 2023
flemzord
pushed a commit
that referenced
this pull request
Dec 4, 2023
flemzord
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.