Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(balances): missing delimiters for regexp #469

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

paul-nicolas
Copy link
Contributor

@paul-nicolas paul-nicolas commented Oct 17, 2023

Fixes ENG-141

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0a8144b) 64.13% compared to head (6cf8d12) 64.13%.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v1.10     #469   +/-   ##
==============================================
  Coverage          64.13%   64.13%           
==============================================
  Files                152      152           
  Lines              14154    14154           
==============================================
  Hits                9078     9078           
  Misses              4486     4486           
  Partials             590      590           
Files Coverage Δ
pkg/ledgertesting/storage.go 72.54% <100.00%> (ø)
pkg/storage/sqlstorage/balances.go 64.86% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paul-nicolas paul-nicolas merged commit 93ed88f into release/v1.10 Oct 17, 2023
20 checks passed
@paul-nicolas paul-nicolas deleted the fix/get-balances branch October 17, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants