Improve gracefulness when invoking wireviz.parse() without file_out argument
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened to be a regression for WireViz-Web [1], which aims to do as much in memory as possible. [1] https://github.com/daq-tools/wireviz-web.
This was referenced Oct 22, 2021
|
Thanks. I am tempted to add this as a hotfix to |
formatc1702
requested changes
Oct 23, 2021
amotl
force-pushed
the
amo/fix-auto-title
branch
from
bb22e6a
to
f729eda
Compare
Merged
formatc1702
approved these changes
Oct 25, 2021
|
WireViz 0.3.1 has been released on PyPI, and it includes the hotfix: |
|
Hi Daniel, thanks for releasing WireViz 0.3.1. After bringing in wireviz/wireviz-web#4, I also just published WireViz-Web 0.3.1. With kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daniel,
this patch would be a fix for the regression we reported and would resolve #253. Let me know what you think about it.
With kind regards,
Andreas.