Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build types #51

Open
4 of 5 tasks
michaem opened this issue Dec 3, 2020 · 3 comments
Open
4 of 5 tasks

Support build types #51

michaem opened this issue Dec 3, 2020 · 3 comments
Assignees

Comments

@michaem
Copy link
Collaborator

michaem commented Dec 3, 2020

Necessary to support build types configurations for debug/release apk's.

Main steps:

  • POC DSL Forma build types
  • Build Types supporting
  • Proguards routines
  • Signing configs
  • Build Fields
@michaem michaem added the enhancement New feature or request label Dec 3, 2020
@michaem michaem self-assigned this Dec 3, 2020
@michaem michaem linked a pull request Dec 14, 2020 that will close this issue
@ikarenkov
Copy link
Collaborator

Do we really need add support for product flavors? Since we have androidBinary we don't need flavors anymore because you can configure concrete build varian in androidBinary. F.e. api endpoint can be stored as res value of androidBinary. Unfortunately we cannot use buildField because we cannot override application buildField from binary

@michaem
Copy link
Collaborator Author

michaem commented Dec 15, 2020

No, we has thought that don't need to do build types as additional to androidBinary targets. Only need to support signing, shrink configurations.
Using res environment of binary targets as configuration sources is interesting idea. Need to checkout this. May be it wouldn't be clearly and explicitly to configure builds.

@michaem michaem removed the enhancement New feature or request label Dec 18, 2020
@michaem
Copy link
Collaborator Author

michaem commented Dec 18, 2020

Need to check out next behaviors:

  • BuildConfig.DEBUG mode
  • Insert properties for Stetho and Canary
  • Dynamic config executes from fun blocks
runIfDebug { 
 // 
}
runIfRelease {
 // 
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants