Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade formbricks-com to latest deps #1866

Merged

Conversation

ShubhamPalriwala
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala commented Jan 9, 2024

What does this PR do?

Upgrade formbricks-com to the latest dependencies!

Next >= 13.5 is causing errors with MDX image parsing as reported here vercel/next.js#58888 hence reverted that upgrade back.

The app now works locally as well as the builds pass too!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 10:40am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2024 10:40am

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@ShubhamPalriwala ShubhamPalriwala marked this pull request as draft January 9, 2024 15:34
@ShubhamPalriwala ShubhamPalriwala marked this pull request as ready for review January 10, 2024 07:36
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks for updating the dependencies 💪🚀

@mattinannt mattinannt added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 69293e2 Jan 22, 2024
12 checks passed
@mattinannt mattinannt deleted the shubham/for-1629-upgrade-npm-packages-in-formbricks-com branch January 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants