Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links and survey overlapping #1985

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix: links and survey overlapping #1985

merged 2 commits into from
Jan 31, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes 1804

Screen-Recording-2024-01-31-at-4.49.18.PM.mp4

How should this be tested?

create a super long question and test it in a phone with short height (iphone SE in dev console)

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview Jan 31, 2024 2:44pm
formbricks-com 猬滐笍 Ignored (Inspect) Visit Preview Jan 31, 2024 2:44pm

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Contributor

apps/web/app/s/[surveyId]/page.tsx

Extracting the email verification logic into a separate function will make the code more readable and maintainable. This will also make it easier to test this functionality separately.
Create Issue
See the diff
Checkout the fix

    const verifyEmail = async () => {
      const token =
        searchParams && Object.keys(searchParams).length !== 0 && searchParams.hasOwnProperty("verify")
          ? searchParams.verify
          : undefined;

      if (token) {
        const emailVerificationDetails = await getEmailVerificationDetails(survey.id, token);
        emailVerificationStatus = emailVerificationDetails.status;
        verifiedEmail = emailVerificationDetails.email;
      }
    }

    if (survey.verifyEmail) {
      await verifyEmail();
    }
git fetch origin && git checkout -b ReviewBot/Impro-rhro5g0 origin/ReviewBot/Impro-rhro5g0

@jobenjada
Copy link
Member

looks good!

@jobenjada jobenjada added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for the fix 馃敟馃殌馃コ

@mattinannt mattinannt added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit f553bce Jan 31, 2024
13 checks passed
@mattinannt mattinannt deleted the link-overlapping-issue branch January 31, 2024 16:02
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Mar 15, 2024
* main: (87 commits)
  fix: remove default env vars in docker compose (formbricks#2018)
  feat: cache web builds & playwright binaries in CI (formbricks#2009)
  chore: prepare 1.5.1 release (formbricks#2012)
  docs: add ClassroomIO to OSS Friends (formbricks#2008)
  feat: Add support for Cloudfront country header (formbricks#2003)
  fix: create survey API expects creator (formbricks#2007)
  fix: ECS deployment GitHub Action (formbricks#2005)
  chore: remove old CLA form from docs & github templates (formbricks#1995)
  fix: ecs github action (formbricks#1992)
  feat: auto subscribing to teams survey responses email (formbricks#1990)
  fix: formbricks-com build errors (formbricks#1991)
  fix: default autocomplete value (formbricks#1986)
  chore: Tweaked survey list (formbricks#1978)
  feat: enable weekly summary & support for callbacks on login (formbricks#1885)
  fix: ecs-deployment.yml (formbricks#1989)
  fix: ECS deployment Github Action (formbricks#1988)
  fix: links and survey overlapping (formbricks#1985)
  fix: Phone validation (formbricks#1987)
  fix: app page redirect throws error (formbricks#1984)
  feat(github action): Add's a new GitHub Action to deploy webapp to ECS cluster (formbricks#1982)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants