fix: Phone validation

[Dhruwang]

What does this PR do?

Fixes # 1786 #1963

How should this be tested?

• Test A
• Test B

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)		Jan 31, 2024 0:34am
formbricks-com	⬜️ Ignored (Inspect)		Jan 31, 2024 0:34am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/surveys/src/components/questions/OpenTextQuestion.tsx

The current phone number validation pattern is a bit too lenient and could be improved to better match common phone number formats. This will help ensure that users enter their phone numbers in a consistent and expected format.
Create Issue
See the diff
Checkout the fix

    pattern={question.inputType === "phone" ? "^\\+?[1-9]\\d{1,14}$" : ".*"}

git fetch origin && git checkout -b ReviewBot/Impro-gp8b3wu origin/ReviewBot/Impro-gp8b3wu

The current form submission process involves a lot of repeated code and unnecessary calculations. By moving the form submission logic into a separate function, we can improve the performance and readability of the code.
Create Issue
See the diff
Checkout the fix

    const handleSubmit = (e) => {
      e.preventDefault();
      const updatedttc = getUpdatedTtc(ttc, question.id, performance.now() - startTime);
      setTtc(updatedttc);
      onSubmit({ [question.id]: value, inputType: question.inputType }, updatedttc);
    };

    // Then replace the onSubmit handlers with this function
    onSubmit={handleSubmit}

git fetch origin && git checkout -b ReviewBot/Impro-wibcpyr origin/ReviewBot/Impro-wibcpyr

[mattinannt]

@Dhruwang thanks for the changes 😊💪