Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default env vars in docker compose #2018

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

ShubhamPalriwala
Copy link
Member

What does this PR do?

Removes default environment variables in docker-compose.yml

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Feb 5, 2024 3:57pm
formbricks-com ⬜️ Ignored (Inspect) Feb 5, 2024 3:57pm

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

docker-compose.yml

It's a good practice to avoid hardcoding sensitive information such as database URLs, secrets, encryption keys, etc., directly in the docker-compose file. Instead, these should be stored in environment variables or secure secret management systems. This change is a step in the right direction. However, to further improve, you can use Docker secrets or environment variables for managing these sensitive data.
Create Issue
See the diff
Checkout the fix

    x-database-url: &database_url ${DATABASE_URL}
    x-nextauth-secret: &nextauth_secret ${NEXTAUTH_SECRET}
    x-encryption-key: &encryption_key ${ENCRYPTION_KEY}
    x-cron-secret: &cron_secret ${CRON_SECRET}
git fetch origin && git checkout -b ReviewBot/Impro-d0bsqn7 origin/ReviewBot/Impro-d0bsqn7

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thank you very much for the quick turnaround! 💪

@mattinannt mattinannt added this pull request to the merge queue Feb 5, 2024
Merged via the queue into main with commit b51e9cc Feb 5, 2024
15 checks passed
@mattinannt mattinannt deleted the shubham/remove-preset-env-vars branch February 5, 2024 16:18
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Mar 15, 2024
* main: (87 commits)
  fix: remove default env vars in docker compose (formbricks#2018)
  feat: cache web builds & playwright binaries in CI (formbricks#2009)
  chore: prepare 1.5.1 release (formbricks#2012)
  docs: add ClassroomIO to OSS Friends (formbricks#2008)
  feat: Add support for Cloudfront country header (formbricks#2003)
  fix: create survey API expects creator (formbricks#2007)
  fix: ECS deployment GitHub Action (formbricks#2005)
  chore: remove old CLA form from docs & github templates (formbricks#1995)
  fix: ecs github action (formbricks#1992)
  feat: auto subscribing to teams survey responses email (formbricks#1990)
  fix: formbricks-com build errors (formbricks#1991)
  fix: default autocomplete value (formbricks#1986)
  chore: Tweaked survey list (formbricks#1978)
  feat: enable weekly summary & support for callbacks on login (formbricks#1885)
  fix: ecs-deployment.yml (formbricks#1989)
  fix: ECS deployment Github Action (formbricks#1988)
  fix: links and survey overlapping (formbricks#1985)
  fix: Phone validation (formbricks#1987)
  fix: app page redirect throws error (formbricks#1984)
  feat(github action): Add's a new GitHub Action to deploy webapp to ECS cluster (formbricks#1982)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants