feat: Add support for Cloudfront country header #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonas-hoebenreich is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
jonas-hoebenreich
changed the title
mattinannt
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
@jonas-hoebenreich thanks a lot for the PR 😊 Looks great! 😊💪
kevinkong91
added a commit
to kevinkong91/formbricks
that referenced
this pull request
Mar 15, 2024
* main: (87 commits) fix: remove default env vars in docker compose (formbricks#2018) feat: cache web builds & playwright binaries in CI (formbricks#2009) chore: prepare 1.5.1 release (formbricks#2012) docs: add ClassroomIO to OSS Friends (formbricks#2008) feat: Add support for Cloudfront country header (formbricks#2003) fix: create survey API expects creator (formbricks#2007) fix: ECS deployment GitHub Action (formbricks#2005) chore: remove old CLA form from docs & github templates (formbricks#1995) fix: ecs github action (formbricks#1992) feat: auto subscribing to teams survey responses email (formbricks#1990) fix: formbricks-com build errors (formbricks#1991) fix: default autocomplete value (formbricks#1986) chore: Tweaked survey list (formbricks#1978) feat: enable weekly summary & support for callbacks on login (formbricks#1885) fix: ecs-deployment.yml (formbricks#1989) fix: ECS deployment Github Action (formbricks#1988) fix: links and survey overlapping (formbricks#1985) fix: Phone validation (formbricks#1987) fix: app page redirect throws error (formbricks#1984) feat(github action): Add's a new GitHub Action to deploy webapp to ECS cluster (formbricks#1982) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the CloudFront-Viewer-Country header to the supported headers. This allows users with CloudFront to also see the user's country.
see https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/adding-cloudfront-headers.html
Fixes # (issue)
How should this be tested?
CloudFront-Viewer-Countryand check if it's visible in FormbricksChecklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated