-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redirect user to email verification page if not done #2241
Merged
mattinannt
merged 2 commits into
main
from
shubham/for-2032-solve-verification-pending-issues
Mar 21, 2024
Merged
feat: redirect user to email verification page if not done #2241
mattinannt
merged 2 commits into
main
from
shubham/for-2032-solve-verification-pending-issues
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
apps/web/app/(auth)/auth/login/components/SigninForm.tsxThe onSubmit function is quite long and complex. It would be beneficial to break it down into smaller, more manageable functions. This would make the code easier to read and maintain. const handleSignInResponse = async (data: TSigninFormState) => {
const signInResponse = await signIn("credentials", {
callbackUrl: searchParams?.get("callbackUrl") || "/",
email: data.email.toLowerCase(),
password: data.password,
...(totpLogin && { totpCode: data.totpCode }),
...(totpBackup && { backupCode: data.backupCode }),
redirect: false,
});
return signInResponse;
};
const handleSignInError = (signInResponse: any, data: TSigninFormState) => {
if (signInResponse?.error === "second factor required") {
setTotpLogin(true);
setLoggingIn(false);
return;
}
if (signInResponse?.error === "Email Verification is Pending") {
router.push(`/auth/verification-requested?email=${data.email}`);
return;
}
if (signInResponse?.error) {
setLoggingIn(false);
setSignInError(signInResponse.error);
return;
}
if (!signInResponse?.error) {
router.push(searchParams?.get("callbackUrl") || "/");
}
};
const onSubmit: SubmitHandler<TSigninFormState> = async (data) => {
setLoggingIn(true);
try {
const signInResponse = await handleSignInResponse(data);
handleSignInError(signInResponse, data);
} catch (error) {
const errorMessage = error.toString();
const errorFeedback = errorMessage.includes("Invalid URL")
? "Too many requests, please try again after some time!"
: error.message;
setSignInError(errorFeedback);
} finally {
setLoggingIn(false);
}
};
|
mattinannt
approved these changes
Mar 21, 2024
mattinannt
deleted the
shubham/for-2032-solve-verification-pending-issues
branch
March 21, 2024 10:48
vidhikapadia2799
pushed a commit
to vidhikapadia2799/formbricks
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Redirects user to Email Verification page where they can request a new email if they want to when they have not verified!
Fixes #2116
How should this be tested?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated