Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip onboarding for invite #2246

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix: Skip onboarding for invite #2246

merged 2 commits into from
Mar 21, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes 2008

How should this be tested?

Test onboarding for

  1. Team invite
  2. ONBOARDING_DISABLED=0
  3. ONBOARDING_DISABLED=1

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 9:50am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2024 9:50am

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

apps/web/app/(auth)/invite/page.tsx

It's a good practice to use destructuring to make the code more readable and clean. This will also help in avoiding repetition of code.
Create Issue
See the diff
Checkout the fix

    const { name, email } = invite.creator;
    sendInviteAcceptedEmail(name ?? "", session.user?.name ?? "", email);
git fetch origin && git checkout -b ReviewBot/Impro-3h0byz3 origin/ReviewBot/Impro-3h0byz3

@@ -44,7 +45,7 @@ export default async function InvitePage({ searchParams }) {
await deleteInvite(inviteId);

sendInviteAcceptedEmail(invite.creator.name ?? "", session.user?.name ?? "", invite.creator.email);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using destructuring to make the code more readable and clean. This will also help in avoiding repetition of code.

Suggested change
sendInviteAcceptedEmail(invite.creator.name ?? "", session.user?.name ?? "", invite.creator.email);
const { name, email } = invite.creator;
sendInviteAcceptedEmail(name ?? "", session.user?.name ?? "", email);

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for the fix :-) looks good, only one thing that needs a change:

apps/web/app/(auth)/invite/page.tsx Outdated Show resolved Hide resolved
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for making the changes; looks good :-)

@mattinannt mattinannt added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 3c80eb3 Mar 21, 2024
12 of 14 checks passed
@mattinannt mattinannt deleted the skip-onboarding branch March 21, 2024 11:45
vidhikapadia2799 pushed a commit to vidhikapadia2799/formbricks that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants