-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Skip onboarding for invite #2246
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
apps/web/app/(auth)/invite/page.tsxIt's a good practice to use destructuring to make the code more readable and clean. This will also help in avoiding repetition of code. const { name, email } = invite.creator;
sendInviteAcceptedEmail(name ?? "", session.user?.name ?? "", email);
|
@@ -44,7 +45,7 @@ export default async function InvitePage({ searchParams }) { | |||
await deleteInvite(inviteId); | |||
|
|||
sendInviteAcceptedEmail(invite.creator.name ?? "", session.user?.name ?? "", invite.creator.email); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using destructuring to make the code more readable and clean. This will also help in avoiding repetition of code.
sendInviteAcceptedEmail(invite.creator.name ?? "", session.user?.name ?? "", invite.creator.email); | |
const { name, email } = invite.creator; | |
sendInviteAcceptedEmail(name ?? "", session.user?.name ?? "", email); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang thanks for the fix :-) looks good, only one thing that needs a change:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang thanks for making the changes; looks good :-)
What does this PR do?
Fixes 2008
How should this be tested?
Test onboarding for
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated