Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI fixes #2653

Merged
merged 3 commits into from
May 20, 2024
Merged

fix: UI fixes #2653

merged 3 commits into from
May 20, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Some small UI fixes, like the z-index fixes throughout the app and the fix in the create action modal.

Screenshot 2024-05-20 at 2 10 08鈥疨M

Screenshot 2024-05-20 at 2 11 06鈥疨M

How should this be tested?

  • Added some screenshots

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview May 20, 2024 9:00am
formbricks-docs 猬滐笍 Ignored (Inspect) Visit Preview May 20, 2024 9:00am

Copy link
Contributor

github-actions bot commented May 20, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for the quick fix :)

@jobenjada jobenjada enabled auto-merge May 20, 2024 09:00
@jobenjada jobenjada added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 10aed2d May 20, 2024
12 checks passed
@jobenjada jobenjada deleted the fix/ui-vs branch May 20, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants